obsidian-calendar-ui icon indicating copy to clipboard operation
obsidian-calendar-ui copied to clipboard

fixed weeknumber displayed on calendar to ISO Week number

Open muejam09 opened this issue 2 years ago • 6 comments

I would recommend using the ISO standard for numbering the weeks of a year. Because for example, for 2022 the plugin shows the wron weeknumber

muejam09 avatar Oct 03 '22 09:10 muejam09

Since there are multiple calendar types, I feel that date.isoWeek() should not simply be used.

  • US calendar begins on Sunday (+ January 1 as the first week) - date.week()
  • EU calendar begins on Monday (+ January 4 as the first week) - date.isoWeek()

like: https://github.com/usagizmo/obsidian-calendar-ui/pull/1

usagizmo avatar Dec 11 '22 07:12 usagizmo

I did not think about that... But wouldn't a option in the settings be the right choice then?
I just saw you tried it with, #19? You stopped working on it because file creation when clicking on the weeknumber did not work?

muejam09 avatar Dec 11 '22 11:12 muejam09

You stopped working on it because file creation when clicking on the weeknumber did not work?

That is one thing, but even if I could fix it, it seems unlikely that the PR would be merged (due to the multiple repositories involved), so I have given up on creating a PR.

usagizmo avatar Dec 11 '22 11:12 usagizmo

Okay... i was confused about this too. Do I understand it correctly, that multiple PR in multiple repositories are needed to make it work correctly?

muejam09 avatar Dec 11 '22 11:12 muejam09

Yes, it is a dependency and requires updating multiple repositories...!

usagizmo avatar Dec 11 '22 11:12 usagizmo

Hi! I think I know why opening the files did not work.. I think it was because of the gggg Setting for the weekly format. It does now work in the new Year. If you switch it to GGGG it already worked in the old year. Atleast thats how i understand it so far.

muejam09 avatar Jan 02 '23 18:01 muejam09