Results 222 comments of Liam Appelbe

There are 4383 headers across 255 frameworks in my Apple SDKs directory (matching `/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/*.framework/Headers/**.h`). When I try to generate bindings for all of them, it runs for 35min then crashes...

There's one more bug that needs to be fixed before this can land: #1220

Tried running this test on the github CI bots in https://github.com/dart-lang/native/pull/1554. Unfortunately they don't really have enough memory to run this test without thrashing (see https://github.com/dart-lang/sdk/issues/56247). So what should be...

Some [notes](https://docs.google.com/document/d/1oDuXV1HaF-erlET3KqMOcLo7lhE-SfqujYeGpw1HcVE/edit?usp=sharing&resourcekey=0-_JgKzeq1FFIknmoSARMUlg) on the transformer pattern.

I was planning to let the transformer support AST node deletion, but I don't think it really makes sense in practice. Most of the children of our AST nodes are...

Ran into a fun DS&A problem. The transform is a DFS, so we need to track whether the nodes are visited. ```dart T transform(T node) { if (_seen.containsKey(node)) return _seen[node]...

> For handling cycles you could "color" the node grey when you enter and black when you finish visiting. But maybe I don't understand the exact problem you're facing. Yeah,...

Remaining minor cleanups: - [x] Remove `Compound.compoundType` - [ ] Remove/refactor `bindingsIndex` - [x] Migrate library sort phase to a visitor, and remove the virtual sort method - [x] Migrate...

Can you rerun your merger tool? This is missing https://github.com/dart-lang/coverage/pull/502 (and https://github.com/dart-lang/coverage/pull/503 but I see you did a similar change yourself).

> hey @liamappelbe! As far as I can understand, this issue focusses on developing a tool which could search for some uncovered files during the test of the project. Could...