Liam Howatt

Results 102 comments of Liam Howatt

While creating the test, I found out that this is not the fix. I tried a few different things but I'm having some difficulties getting something to work for all...

It's very close. But still faces some of the same problems. I did try rewriting it but I ended up re-inventing everything that's already there, including `corr` :slightly_smiling_face:, and then...

Progress report 🚧️ WIP 🚧️ The progress so far has been directed by getting the number of lines output by this command near zero. ``` gcc -std=c11 -E -Wno-incompatible-pointer-types -DLV_LVGL_H_INCLUDE_SIMPLE...

Hey @kisvegabor, it looks like losing APIs isn't going to be a problem. After I push a cleaned up commit, what are the things we want to do to get...

I'm not sure why CI isn't running. FYI here are the JSONs generated by the API JSON generator. `lvgl.h` `master`: [lvgl_master.json](https://github.com/lvgl/lvgl/files/15182746/lvgl_master.json) `lvgl_private.h` `master`: [lvgl_private_master.json](https://github.com/lvgl/lvgl/files/15182749/lvgl_private_master.json) `lvgl.h` `refactor/api`: [lvgl_refactor.json](https://github.com/lvgl/lvgl/files/15182752/lvgl_refactor.json) `lvgl_private.h` `refactor/api`: [lvgl_private_refactor.json](https://github.com/lvgl/lvgl/files/15182753/lvgl_private_refactor.json)

I typedef'd as many enums as I could, but I left them for a reason, originally. - `lv_part_t` and `lv_state_t` are typedef'd in lv_types.h to avoid circular dependencies. [See this](https://github.com/lvgl/lvgl/pull/5161#issuecomment-1875056420)....

It's public headers including each other. It's lv_obj.h and lv_obj_style.h including each other.

> what is in lv_obj.h that would need to include from lv_obj_style.h?? lv_obj_style.h needs `lv_part_t` which is currently in lv_types.h as `typedef uint32_t lv_part_t;` but I'm trying to remove it...

Maybe the `lv_part_t` enum AND its members could go in lv_types.h :raised_eyebrow: