liam icon indicating copy to clipboard operation
liam copied to clipboard
verified publisher icon liam-hq

Remove the approval of `@electric-sql/client` package in License Decisions file

Open FunamaYukina opened this issue 10 months ago • 2 comments

Task description

Remove the approval of @electric-sql/client package in License Decisions file

https://github.com/liam-hq/liam/blob/48d2c7af8ab9007655eda92608ce275fb00726e9/config/dependency_decisions.yml#L113-L118

Background

The license was specified in https://github.com/electric-sql/electric/blob/main/LICENSE , but the npm package said Apatch-2 instead of Apatch-2.0, so we had to temporarily add @electric-sql/client to the License Decisions file.

TODO (Optional)

  • [x] https://github.com/liam-hq/liam/pull/846 was merged
  • [x] Notation of npm package is corrected.（https://github.com/electric-sql/electric/pull/2436 ）
    • https://www.npmjs.com/package/@electric-sql/client
  • [ ] Remove the approval of @electric-sql/client package in License Decisions file

Additional notes (Optional)

FunamaYukina avatar Mar 12 '25 03:03 FunamaYukina

https://github.com/electric-sql/electric/pull/2436 was merged.

Once the next version of @electric-sql/client is released and Liam starts using it, we can begin working on this issue.

masutaka avatar Mar 26 '25 02:03 masutaka

Version 1.0.1, in which the license was corrected from Apache-2 to Apache-2.0, has been released. https://www.npmjs.com/package/@electric-sql/client

Once Liam starts using @electric-sql/client version 1.0.1 or later, we can begin working on this issue.

masutaka avatar Apr 03 '25 05:04 masutaka

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Jun 02 '25 13:06 github-actions[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Aug 02 '25 13:08 github-actions[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Oct 03 '25 13:10 github-actions[bot] 

❯ pnpm -r why @electric-sql/client

It does not appear to be included in the dependency at present.

MH4GF avatar Oct 06 '25 00:10 MH4GF