liam icon indicating copy to clipboard operation
liam copied to clipboard

Make it easier to display tooltips for table names

Open sasamuku opened this issue 10 months ago โ€ข 14 comments

Task description

Expand hover range to ~~table header~~ table node instead of table name span.

Current behavior:

https://github.com/user-attachments/assets/8d9eb89e-b517-48a3-8184-9f754c75290f

Background

Since long table names are truncated, it is necessary to hover over a table name to display a tooltip to see all table names. The hover area is Span of the table name, which is difficult to display because the range is small.

TODO (Optional)

  • [ ]
  • [ ]
  • [ ]

Additional notes (Optional)

sasamuku avatar Feb 21 '25 05:02 sasamuku

@kumanoayumi Can you check to see if the experience is comfortable from a UX designer's perspective?

MH4GF avatar Feb 25 '25 02:02 MH4GF

@MH4GF @zaza

Rather than extending the hover area to the table header as a display trigger for tooltips, it would be a wider and better experience to determine the entire table as a hover area. Are there any implementation trade-offs?

kumanoayumi avatar Feb 25 '25 02:02 kumanoayumi

@kumanoayumi Sorry for the late reply. I think we can choose the better experience without worrying about the technical trade-offs.

As you said, this looks like a better experience. (If supporting truncated column names in the future, we need to avoid conflicting tooltips.)

https://github.com/user-attachments/assets/3763194e-6f6c-49b3-b66a-9ebefef2f2eb

sasamuku avatar Feb 27 '25 07:02 sasamuku

@sasamuku

(If supporting truncated column names in the future, we need to avoid conflicting tooltips.)

Yeah, to avoid conflicting tooltips, we could separate the tooltip display for tables and columns by utilizing a custom data attribute such as data-tooltip-type. That way, each tooltip behaves independently. ๐Ÿ’ญ

kumanoayumi avatar Feb 27 '25 07:02 kumanoayumi

@kumanoayumi Thank you, we can deal with that when we have conflicting tooltips๐Ÿ‘

sasamuku avatar Feb 27 '25 10:02 sasamuku

This Issue is ready ๐Ÿš€

Expand hover range to ~~table header~~ table node instead of table name span. https://github.com/liam-hq/liam/issues/764#issue-2868026027

sasamuku avatar Feb 27 '25 10:02 sasamuku

i would like to work on this issue!

prakha avatar Mar 05 '25 18:03 prakha

@prakha Great! Go ahead ๐Ÿ‘

sasamuku avatar Mar 06 '25 00:03 sasamuku

@MH4GF this issue was not resolved in this pull request.

prakha avatar Mar 10 '25 05:03 prakha

@prakha Oh!! You're right. https://github.com/liam-hq/liam/issues/794 is correct.

MH4GF avatar Mar 10 '25 05:03 MH4GF

@MH4GF, @sasamuku I have created a pull request. Should I submit it again, or are there any changes needed from my end?

prakha avatar Mar 23 '25 21:03 prakha

https://github.com/user-attachments/assets/25d88c91-0b13-4331-beb3-aa935485659d

prakha avatar Mar 30 '25 13:03 prakha

@MH4GF, @sasamuku i have created the pull request #1039.

prakha avatar Mar 30 '25 13:03 prakha

@prakha Thank you ๐Ÿ˜„ Additionally, could you please adjust the tooltip so that it only comes up when the table name is omitted? We want to offer the same experience as LeftPane.

MH4GF avatar Apr 01 '25 03:04 MH4GF

We will continue with #1665.

MH4GF avatar May 13 '25 04:05 MH4GF