liam icon indicating copy to clipboard operation
liam copied to clipboard
verified publisher icon liam-hq

The hidden & active query parameter is not reflected in the ER diagram during back/forward navigation

Open MH4GF opened this issue 11 months ago • 8 comments

Self Checks

  • [x] This is only for bug report, if you would like to ask a question, please head to Discussions.
  • [x] I have searched for existing issues search for existing issues, including closed ones.

Cloud or Self Hosted

Cloud

Version (only for Self Hosted)

No response

Steps to reproduce

Go to https://liambx.com/erd/p/github.com/mastodon/mastodon/blob/main/db/schema.rb?active=accounts

https://github.com/user-attachments/assets/a14edb4c-fa9f-44d5-8487-cd3ed6e2eea7

Expected Behavior

Table highlight and hidden state of table can be transitioned by back/forward navigation.

Actual Behavior

No response

Additional Context

I want it fixed so that this test passes.

https://github.com/liam-hq/liam/blob/26c024bc70c1ff0132ec85c527d6b7891cb293d0/frontend/packages/e2e/tests/e2e/navigation.test.ts#L95

MH4GF avatar Feb 17 '25 05:02 MH4GF

is this issue open, can i work on this issue??

prakha avatar Mar 23 '25 21:03 prakha

@prakha How wonderful you are 🚀

MH4GF avatar Mar 24 '25 11:03 MH4GF

hii @MH4GF, i am thinking of reloading the page when there is forward and backward navigation.

Image

prakha avatar Apr 01 '25 03:04 prakha

will that be okay

prakha avatar Apr 01 '25 03:04 prakha

@prakha If possible, we would like to implement this without reloading. Do you remember where the selection state is reflected? @junkisai That implementation should be helpful.

MH4GF avatar Apr 01 '25 03:04 MH4GF

@prakha @MH4GF The hook that controls the ERD display state when using the browser's back/forward buttons is usePopStateListener. https://github.com/liam-hq/liam/blob/main/frontend/packages/erd-core/src/features/erd/components/ERDContent/hooks/usePopStateListener.ts

It seems that the behavior reported in this issue is occurring due to either an error in the implementation of this hook itself, or in one of the functions used within the hook.

junkisai avatar Apr 01 '25 05:04 junkisai

Image

prakha avatar Apr 02 '25 23:04 prakha

@MH4GF , @junkisai i have created the pull request. #1091

prakha avatar Apr 03 '25 00:04 prakha

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Jun 02 '25 13:06 github-actions[bot]