Chen Liang
Chen Liang
The feature added in #131 has proven to be more adverse than beneficial. It greatly hampers javadoc addition, and I suggest reverting it so we can add javadoc more easily...
In the later Minecraft versions, vanilla adds NBT path, which is much similar to sponge's dataquery except that one NBT path can represent multiple targets at once with its filtering...
Generic repositories, the implementation detail for generic information in core reflection, can be updated to use the `@Stable` annotation to replace their `volatile` access. Their existing accessor code is already...
Last time, Zidane mentioned when ST-DDT contributed AI docs on SpongeDocs that the whole AI system (agent goals/tasks) will be revamped. I have a few notes for these changes: Goal...
The inline return javadoc tag does not need a colon as javadoc adds one for it. need an exceptional rule for checkstyle.
E.g. https://github.com/FabricMC/fabric/blob/dfd0b839f4ea14da86c0ac92db3f60a6128d1a30/fabric-registry-sync-v0/src/main/java/net/fabricmc/fabric/api/event/registry/FabricRegistryBuilder.java#L66-L68 can just become ```java public static FabricRegistryBuilder createSimple(Identifier registryId) { return from(new SimpleRegistry(RegistryKey.ofRegistry(registryId), Lifecycle.stable())); } ``` Vanilla's generic type on the stupid registry key thing is just a...
Preview changes for #452. Should be ready to fly, but will add a test mod later.
Currently loader refuses to load client-side libraries in standalone jars with knot, yet it loads server-embedded libraries with knot. I suggest loading them in the same fashion, presumably start loading...
From https://github.com/FabricMC/tiny-remapper/issues/46#issuecomment-871498309 See https://github.com/FabricMC/fabric-loader/blob/44c957c685bd0bc0160553381e134ac2775330e0/src/main/java/net/fabricmc/loader/impl/transformer/FabricTransformer.java#L49 this package access handling could have been done at https://github.com/FabricMC/fabric-loader/blob/44c957c685bd0bc0160553381e134ac2775330e0/src/main/java/net/fabricmc/loader/impl/launch/FabricLauncherBase.java#L80 to create an access-fixed jar instead. cc @sfPlayer1 for better suggestions/alternatives if there is any. Does...
#370 proposes to add an environment field to a mod dependency. https://github.com/FabricMC/fabric-loader/pull/461#discussion_r661411557 suggested to make environment field more generic by creating a built-in mod for the minecraft client. Combining this...