jquery-match-height icon indicating copy to clipboard operation
jquery-match-height copied to clipboard

Not working when I increase the font size

Open wilsontse88 opened this issue 8 years ago • 8 comments

I added the font size button, that increase the font size ( smaller, reset ,and larger),but the height of div / table not updated their height.

Then , how can i solve this issue..??

Thanks

wilsontse88 avatar Oct 17 '16 17:10 wilsontse88

After increasing the font-size you probably have to update matchHeight. Perhaps you also could monitor if the size is changing by an event-Handler but I haven't done something like that yet so you have to try by yourself. At least you've to call always the update-function if you expect a changed size.

DavidBruchmann avatar Oct 17 '16 19:10 DavidBruchmann

But I added $.fn.matchHeight._update() this code, however, still cannot update the div height...

Am i wrong in coding???

wilsontse88 avatar Oct 18 '16 01:10 wilsontse88

Probably you're wrong in coding, yes. But that's hard to prove without enough code.

DavidBruchmann avatar Oct 18 '16 03:10 DavidBruchmann

THe font size problem is fixed. But there is another problem in FF. I used chrome and IE9+ is okay and fit the height of table. but some of the tables that screen2 cannot same height in FF. Do you know why ??

wilsontse88 avatar Oct 18 '16 06:10 wilsontse88

Don't know but seems you've still to optimize, the short entries in the top take much empty space while the one cell with much content is relative small. Looks like your cells are styled to take max 2-3 lines below the headline and if more lines the layout is broken. I think in your case it wouldn't be seen if you remove border-bottom, just make border-top instead. The whole section still can get border-bottom.

DavidBruchmann avatar Oct 18 '16 06:10 DavidBruchmann

I change the bordor-bottom to border-top. But still no luck in FF. screen2

does this plugin are not capable to support the FF ??

wilsontse88 avatar Oct 18 '16 07:10 wilsontse88

I just see your html with all the tables. As I'm not the producer of jquery-match-height I don't know if it might be a problem but I think you should replace the tables by divs or other elements.

On Tue, Oct 18, 2016 at 2:24 PM, wilsontse88 [email protected] wrote:

I change the bordor-bottom to border-top. But still no luck in FF. [image: screen2] https://cloud.githubusercontent.com/assets/8359718/19468028/ec921728-9546-11e6-90d2-09fd9564628d.png

does this plugin are not capable to support the FF ??

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/liabru/jquery-match-height/issues/131#issuecomment-254427817, or mute the thread https://github.com/notifications/unsubscribe-auth/AA8-6sf00lgg4tEgDc3kzmy9-prgEoisks5q1HRGgaJpZM4KY6mA .

DavidBruchmann avatar Oct 18 '16 07:10 DavidBruchmann

I'd expect that there might be problems matching heights of table based elements, because they are naturally difficult to control using CSS (by design). I think we'd need a working example link to be able to help more here, if you could provide?

liabru avatar Oct 19 '16 11:10 liabru