Results 81 comments of lhy11009

I have another case comparing two options of the parameter: (left subfigure) `set Interpolation scheme = harmonic average` (right subfigure) `set Interpolation scheme = cell average` These cases are lower...

Okay I think it goes into this function in the advection.cc file: ` AdvectionSystem::execute`, and here is where it's being parsed in: ` const double reaction_term = ((advection_field_is_temperature) ? 0.0...

Hi @gassmoeller,Thanks for the information. I'll check that out first and keep this issue open for further conversation.

Hi Sibiao, thanks for forwarding this to me. Magali just recompiled 4.3.2 last weekend on peloton. I'll cc her to let her know. I'll test my model run times and...

@MFraters, @mibillen I had a temporary fix for this issue (block GMG fails after the cheap stokes in an iterated solver). The fix is to skip the expensive stokes after...

I just summarize what we discussed 09272023 (@mibillen ) - @MFraters mentioned the issue with switching from cheap to expensive stokes, but not if we just use cheap or expensive...

Thanks again, @anne-glerum. I have provided a review for every point you addressed. Meanwhile, I added some description of this piece of contribution and of the test I generated with...

@anne-glerum Feel free to point out more issue to address. I also added some description at the start of the PR, as well as a visualization of the test results....

@gassmoeller. Thanks for your comments on the PR. We have discussed the reason to have this implementation is to have it handle a more complex scenario in the phase transitions....

The idea of this PR is to only change the interface of the parse_map_to_double_array function so that the value exported from it remains the same no matter if the differences...