lhy11009
lhy11009
Here is an illustration of the density variations: A) Pyrolite, B) Harzburgite, C) Basalt (Arredondo & Billen 2017). These come from the visualization of the three tests I enlisted here....
Hi @jdannberg, thanks for your valueble reviewing. I have addressed all of them in the source code. Moreover, I found your questions really hitting the heart of the issue. I'll...
@jdannberg There seems to be a weird bug with the line we added for the maximum value in "utilities.cc". I don't have this issue building it on my local machine.
@jdannberg, sure, we could meet and decide what to do. I'll ask @mibillen to join. Maybe next week's biannual meeting is a good time?
@jdannberg Okay, Let's plan on discussing it there. If it comes down to implementing a new EOS, I think I could alos handle it with your help. So, I guess...
In this PR, I handled the change of the inputting method of properties (e.g. density, viscosity) on phases. Now, the properties could both be assigned by values or by values...
This may seem confusing at the first sight. I added a function "parse_map_differences_to_values" in "material_model/utilities.cc" file to deal with the new ways of input - take the inputs of differences...
Hi, would anyone jump in and take this review. Thanks for your help.
@anne-glerum. By any chance, do we have reviewers available for this PR? No hurry, I am just commenting here in case it's been forgotten.
@anne-glerum, a gentle reminder, do you have time to review this again?