sendxmpp icon indicating copy to clipboard operation
sendxmpp copied to clipboard

Allow sending message without subject

Open andrey-utkin opened this issue 7 years ago • 4 comments

When I watch received messages in mcabber, I see it like below. Even if --subject arg is not used, it still sends empty subject (see []). It would be handy to be able not to send subject field altogether.

 #[C] #dragonbox-pyra  │09-08 21:01 <== []                                                                                                                                                     
  [x] #elinux          │                test                                                                                                                                                   
  [C] #ffmpeg          │                                                                                                                                                                       
  [C] #ffmpeg-devel    │09-08 21:04 <== [subject]                                                                                                                                              
  [x] #gentoo          │                test                                                                                                                                                   
  [C] #gentoo-arm      │                                                                                                                                                                       
  [C] #gentoo-embedded │09-08 21:06 --> hey                                                                                                                                                    
  [C] #gentoo-hardened │09-08 21:06 <== [subject]                                                                                                                                              
  [x] #gentoo-kde      │                test                                                                                                                                                   

andrey-utkin avatar Sep 08 '16 21:09 andrey-utkin

I have the same issue. I got one property in schema "default": null and this fails.

Were you able to find a fix?

roshan-lanewala avatar Feb 06 '18 04:02 roshan-lanewala

This is not a fix but i have a workaround that i posted in #152

I did some research and the big actually looked like it was in angular ... it did not check the existence of an object before running the foreach on it. So i might be remedied in future angular updates. However I never opened a ticket in angular (i would have to refind the code).

tmburnell avatar Feb 06 '18 15:02 tmburnell

Any progress in this issue?

akvaliya avatar Mar 28 '19 13:03 akvaliya

problem is here:

    FormGroup.prototype.patchValue = function (value, options) {
        var _this = this;
        if (options === void 0) { options = {}; }
        Object.keys(value).forEach(function (name) {
            if (_this.controls[name]) {
                _this.controls[name].patchValue(value[name], { onlySelf: true, emitEvent: options.emitEvent });
            }
        });
        this.updateValueAndValidity(options);
    };

because this function assumes that value is object, not null. There isn't any typecheck before Object.keys(value) is called.

GonziHere avatar Apr 13 '19 16:04 GonziHere