Quentin Lhoest

Results 416 comments of Quentin Lhoest

What about updating the section about "manual download" ? I think it goes there no ? https://huggingface.co/docs/datasets/v2.4.0/en/loading#manual-download

Thanks ! Pinging @albertvillanova to review this change, and then I think we're good to merge

Just took your comment into account @mariosasko , let me know if it's good for you now :)

If the error only happens on 3.6, maybe #4460 can help ^^' It seems to work in 3.7 on the windows CI > inferring labels is not the default behavior...

If a metadata.jsonl file is present, then it doesn't have to infer the labels I agree. Note that this is already the case for imagefolder ;) in your case `load_dataset("audiofolder",...

Feel free to merge the `main` branch into yours after updating your fork of `datasets`: https://github.com/huggingface/datasets/issues/4629 This should fix some errors in the CI

Why don't we deprecate label renaming already instead ?

I'm worried it's a bit of a waste of time to continue working on this behavior that shouldn't be here in the first place. Do you have a plan in...

I see ! Could it be possible to not add `auto_rename_labels` at all, since you want to remove it at the end ? Something roughly like this: 1. show a...

Sounds good to me ! To summarize: 1. add the label renaming logic in `transformers` + release 1. show a warning in `to_tf_dataset` whevener a label is renamed automatically, saying...