Quentin Lhoest

Results 416 comments of Quentin Lhoest

We are deprecating the metrics in `datasets` indeed and suggest users to switch to `evaluate` (via a warning message) We'll keep the current metrics as they are for now, but...

I guess this is ready to merge ? It should break nothing except one rare case: If someone is using an old version of `datasets` to try to load a...

Let's merge this on monday if we can, to make sure contributors who wanted to merge their dataset PRs here could do it

Following the discussion in #3045 if would be nice to have a way to let users have a nice experience with caching even if the function is not hashable. Currently...

Hi ! I think this can be fixed by letting the config_kwargs take over the builder kwargs here: https://github.com/huggingface/datasets/blob/7feeb5648a63b6135a8259dedc3b1e19185ee4c7/src/datasets/load.py#L1533-L1534 maybe something like this ? ```python **{**builder_kwargs, **config_kwargs} ``` Let me...

Cool thank you ! Let me know if you have questions or if I can help

Ok I see - maybe we should check the values of builder_kwargs raise an error if any key in config_kwargs tries to overwrite it ? The builder kwargs are determined...

> Let's keep in mind users might rely on dataset_infos.json already. Yea we'll full full backward compatibility > Let's also keep in mind that extracting YAML metadata from a markdown...

> do users often parse datasets_infos.json file themselves? Not AFAIK, but I'm sure there should be a few users. Users that access these info via the `DatasetInfo` from `datasets` won't...