lforms-fhir-app icon indicating copy to clipboard operation
lforms-fhir-app copied to clipboard

Caching valueset expand within a single load

Open vadi2 opened this issue 2 years ago • 2 comments

An idea - while loading a single Questionnaire that has a lot of questions tied to the same answer valueset, would it be worthwhile to re-use the existing available valueset expansion to reduce the number of network calls?

https://user-images.githubusercontent.com/110988/170924577-5c759d2c-2bf2-4492-b3ff-0509588d1a81.mov

vadi2 avatar May 30 '22 05:05 vadi2

That is surprising, because the code was written to cache those, so there must be a bug in it. Could post a small test case, say with two questions which cause the same ValueSet to be fetched twice?

plynchnlm avatar May 31 '22 14:05 plynchnlm

You bet, here it is:

lhcforms-21-testcase.zip

vadi2 avatar Jun 02 '22 11:06 vadi2