lhespress
[SUGGESTION] Rename new radio type from znsp to either espznsp or espzb instead (so less easy to confuse/misstake for znp)
Suggest renaming the new radio type for this from znsp to either espznsp or espzb instead, (for IMHO several very good reasons).
That way the radio type will have "esp" in the name which will better match the name of the library and products is compatible with.
It would also made it read less similar to the existing znp radio type that is already used by the zigpy-znp radio library, so more unique.
Cross-post from here -> https://github.com/zigpy/zigpy-cli/issues/45#issuecomment-2003163382
@lhespress nitpicking and maybe trivial, however as suggested by puddly in https://github.com/zigpy/zigpy-cli/pull/42 perhaps would it not be a a good idea before this is established if also the new radio type was renamed from znsp to either espznsp or espzb instead to it both has "esp" in the name and better match the name of the library so that it does not sound too similar to existing znp radio type that is used by the zigpy-znp radio library?
Perhaps just my dyslexia but reading znsp and znp as block words then they look similar to me at a glance. So at least I think that might make it a little less likely that the radio type name is accidentally confused with znp by users, or what do you think?
https://github.com/zigpy/zigpy-cli/pull/45/commits/39f6642aed66bea1ba5145e5c587655f8fae57b6#diff-bb72967ef9d1e64ff68ad3f1a4e13e19b4cc7f05359c100016f76560fbaea52c
https://github.com/zigpy/zigpy-cli/blob/39f6642aed66bea1ba5145e5c587655f8fae57b6/zigpy_cli/const.py#L17
https://github.com/zigpy/zigpy-cli/blob/39f6642aed66bea1ba5145e5c587655f8fae57b6/zigpy_cli/const.py#L62
@lhespress Do you have any more thoughts on these name change suggestions?
Again, please see all related comments in your pull request for zigpy-cli here -> https://github.com/zigpy/zigpy-cli/pull/45
@lhespress Any update about this? This suggestion was also brought up here:
- https://github.com/zigpy/zha/issues/415#issuecomment-2793214803
as well as here:
- https://github.com/zigpy/zigpy-cli/issues/45#issuecomment-2003163382
Again not a must but a good idea to decide on before those are merged.
