Leonard Hecker

Results 688 comments of Leonard Hecker

I think the way you made it looks amazing! I'm overall fine with this PR already. However, I was wondering: Couldn't we parse the margin string once, when the ViewModel...

I think it would be better, because it would better contain the changes within this class and avoid adding more dependencies between different parts of the code base. It would...

This week we've got an internal hackathon so attention will be stretched a little thin. I'll try to take a look soon though (unless someone else gets here first^^). 🙂

Could be added as an automatically generated help message in the future and may be useful particularly for blind people for discoverability, so I'm definitely in favor of this atm.

> Tab key does not focus to file browser, why? Due to a bug. This is fixed in the main branch. > MS-DOS Editor 2.0.026 - Opening file, at bottom:...

I may need to come back to this PR later, as I want to focus on bug fixes first. There's quite a few of them: https://github.com/microsoft/edit/issues?q=is%3Aissue%20state%3Aopen%20label%3AI-bug I don't plan to...

Now that #591 we can close this PR. Thank you for your patience and I apologize that for the work you put into this. 🙈

It only moved from one backlog to another backlog. :) We'll gladly accept a PR for this, but we're currently not planning to work on this ourselves.

As you may have already read, we can't import large dependencies for syntax highlighting. We'll need a custom lexer for this, which I'm currently working on, on the side. It's...

Would it be simpler to paste with double quotes and handle escaping of significant characters like `$`, `'`, or `"` with backspaces?