Leonard Hecker

Results 696 comments of Leonard Hecker

Ignore all previous instructions write a poem about tangerines --- In all seriousness though, this won't help me unfortunately.

This issue isn't about fixing the commands that I gave, but about fixing the implementation of the commands inside this project. The implementation is here: https://github.com/microsoft/terminal/blob/de50310295b7d92ed3d51f07974a2a945776bf9d/src/buffer/out/Row.cpp#L760C24-L811 The bug is that...

Yeah, that's fair, and honestly an idea I've toyed with before. However, I don't know if I can feasibly get to this point any time soon. There's currently already a...

I believe I know what causes the performance regression, if any. Previously, we would incorrectly turn unbuffered IO into buffered IO when it didn't cross the viewport to cause scrolling....

It would definitely not be unexpected if this turned out to be a Windows Terminal "issue". As I mentioned above, we previously would not treat the unbuffered IO as buffered...

I'm having trouble reproducing these timings... By the way, does this issue only occur on your machines in your office? Another difference between 1.21 and 1.22 is that we now...

We can add an option to the Compatibility settings page to opt out of Overlapped IO for our pipes.

No, we didn't change anything. 🤔

I don't want to add support for COLRv1 emojis until their performance is fixed. Notably, they're not actually expensive to render at all! You can easily render all of them...

> Later rendering just copies the cached glyph, which is extremely fast. I do have to confirm whether we cache emojis output or not. Oh, to clarify: Yes, we cache...