Leonard Hecker

Ah, I see now... I believe the correct fix would actually be to move the `PaintSelections` call from `Renderer::_PaintSelection` to (for instance) `Renderer::_PaintBackground`. Also, I just noticed I really need...

Hmm... Is it really necessary to use the cluster map at all? Any modifications we make to the foreground color bitmap before `PaintBufferLine` gets called will end up colorizing the...

I'm not sure how obvious this since I've authored the code. So just to make sure I'll explain it: The purpose of the color bitmaps (both are in `_p.colorBitmap`) is...

I apologize for the late review. I was sort of hung up in graphemes and some other work. To be honest, I have some concerns with this PR, primarily due...

(As mentioned in the other PR, I'm currently hung up in finishing up a massive PR myself. I'll review your PR as soon as I'm done with that. Should be...

Hey! I believe #14979 is very similar to what you're describing and was closed as a duplicate of #10694, #10496 and #10119. I think we should close this issue as...

FWIW I'm still somewhat worried about putting the `PageManager` into the VT specific code. However, I don't think I could suggest an alternative. As we've talked about many times before,...

I don't think you need to worry about the performance too much - The regression is rather small. I forgot how much it was, but it was like -5% or...

Ah that's fine then. We're about to fork off release-1.21 now and I think afterwards we can merge it (for version 1.22). I can't speak for them, but it may...

What we currently support are TraceLogging events of the `Microsoft.Windows.Console.Host` provider, aka `fe1ff234-1f09-50a8-d38d-c44fab43e818`. It contains an output similar to vtm:  We have instructions to record a trace here: https://github.com/microsoft/terminal/wiki/Troubleshooting-Tips#capturing-a-debug-etl-trace...