Leonard Hecker

I work on Windows Terminal and I've found that Windows Terminal Preview 1.18 started crashing when MacType is used. This appears to happen because it calls `ID2D1Device4::SetMaximumColorGlyphCacheMemory` and EasyHook seems...

@snowie2000 The PR that I sent you last year fixes this bug (#938). @sangiye0 The fix is in the latest RC: https://github.com/snowie2000/mactype/releases/tag/v1.2023.5.31

> It does seem like we lost tests for the actual replacements (input redir, output redir, etc, etc), I'll check whether they were covered by the `TestMatchAndCopy` test. Since the...

Yep, looks good. Seems like everything is still covered thankfully. 🙂

I'll be closing this issue then. 🙂

Oww, that's unfortunate to hear. 😕 My series of PRs around the flushing of VtEngine really isn't particularly great, and I'm fairly dissatisfied with them. I couldn't think of an...

> However, you're right. There's something odd happening here. Both the Windows Console and Terminal do this differently than urxvt and Konsole on the same system/configuration. I've looked into this...

I'll try to review your PR sometime later this week and hopefully help you with designing the new TextBuffer functions. I'm currently trying to finish up a massive, rather complex...

I've reviewed the code now and I think it's ready to merge. Ideally we would replace all those boolean parameters with something "more compact", an enum, struct, or something else,...

> Is it meaningful to differentiate the padding from the gutters? @DHowett I'm not sure the distinction is obvious, since OP refers to what you call "gutters" as the "padding"...