Les Hazlewood

Results 239 comments of Les Hazlewood

Just a note: this will be easier when #113 is complete as JWK support is required for JWE.

Thanks @bturner for the issue! (@bdemers, Bryan and I go *way* back - he was the very first Stormpath engineer! 😎 ) And agreed, `Assert.notNull` will indeed throw an exception,...

When looking at the current exception hierarchy in the `jwe` branch, perhaps a new `HeaderException` branch makes sense (to somewhat parallel the `ClaimException` hierarchy): ![image](https://user-images.githubusercontent.com/121180/158691872-fd718d32-b7bf-4832-ac98-e0586c7221a5.png) There is a `UnsupportedKeyException` class,...

Thanks for the insight Bryan - we can definitely add these suggestions. I do really like the Header being included in the exception - that makes total sense. Unfortunately, I...

Not stale, but it is probably resolved in the `jwe` branch with the addition of the new `Locator` interface, and that does indeed document that a null return value means...

Just a note as I think about this: This could impact the [jwe](#178) branch. Implementations there currently assert `ECKey && PrivateKey` or `ECKey && PublicKey` and similar for `RSAKey` concepts...

@bdemers wanna update this based on latest master?

@bdemers I seem to remember you working on similar HTTPS resolution logic for this stuff at one time, no? Any insights into this that I need to be aware of?...