naivecoin icon indicating copy to clipboard operation
naivecoin copied to clipboard

Redundant Validity check.

Open jfsuarezb opened this issue 4 years ago • 1 comments

https://github.com/lhartikk/naivecoin/blob/35237fbdedd703126bf9baea1d335b9bc2e12fb4/src/transaction.ts#L162

Why is the equality between the unspent transaction id and the new transaction uxto reference id being checked for twice? Why can't you just do uTxO.txOutId === txIn.txOutId instead of uTxO.txOutId === txIn.txOutId && uTxO.txOutId === txIn.txOutId?

jfsuarezb avatar Jul 08 '20 23:07 jfsuarezb

They might have wanted to say uTxO.TxOutIndex == txIn.TxOutIndex && uTxO.TxId == txIn.TxId

qwertyuu avatar Oct 20 '21 01:10 qwertyuu