Larry Gritz

Results 616 comments of Larry Gritz

Gotcha, will fix that, too! (And, ugh, check the others. :-))

I think the fixes I already made will fix that case. But perhaps it's also best if that code closes the file unconditionally. I may need to do some additional...

I would go even farther and say that most of the unaccounted memory is probably data held internally to the underlying format libraries (libIlmImf, libtiff, etc) which are hidden behind...

To try to track this down, I made #3023, but it passes CI, which uses MSVC 19.16.27045.0 and 19.29.30038.1. You said you were experiencing this with MSVC 14.28.29910, which must...

Sorry about missing this one. There are two problems here. First, a valid initialized ImageSpec that can actually describe an image or a buffer MUST have a meaningful `format` field...

I'm not sure how to test this and know that I've done it correctly. If you know what needs to be done, I don't suppose you'd be willing to take...

This already exists, it's just that it's split into two calls. Underneath, `--trim` is just doing: ImageBuf img; // your image // Find the smallest rectangle containing all the non-zero-valued...

I want to re-open so that at the very least, I have a reminder to fix the docs. Can you elaborate on "not quite as simple"? If the empty non-zero...

Yeah, in an OpenEXR-centric world, this makes sense. For many other file formats which don't support the full generality of data and display windows, you may end up cropping to...