Lars Göttgens

`canonical_unit` implementations differ from docs

7

I thought about adding some conformance checks for `canonical_unit` via adding ```julia @test is_unit(canonical_unit(a)) @test equality(canonical_unit(a * b), canonical_unit(a) * canonical_unit(b)) ``` after [this line](https://github.com/Nemocas/AbstractAlgebra.jl/blob/3d743292f4cd1ae3b71845d50363dc781778afec/test/Rings-conformance-tests.jl#L110). The reasoning comes from the...

`canonical_unit` does not always return a unit

3

In my understanding of the documentation of the function `canonical_unit` (cf. #1153), this should always return a unit to allow for some canonicalization of an element `x` up to units...

Adapt QQBar documentation

3

Some more progress towards https://github.com/oscar-system/Oscar.jl/issues/3416. This follows the approach of https://github.com/oscar-system/Oscar.jl/issues/3416#issuecomment-2047092266, i.e.: - preparing for removal of `CalciumQQBar` (global constant) - preparing for unexporting `QQBar` (global constant) - adapt the...

```julia julia> F, i = cyclotomic_field(4) (Cyclotomic field of order 4, z_4) julia> dot(i,i) -1 ``` any textbook definition would tell you that the result is `1` Hecke number fields...

Make `deepcopy_internal` inferrable for BigInt and BigFloat

1

I noticed this is not inferrable/typestable when looking at a `deepcopy_internal` implementation of one of my own types using JET. ```julia deepcopy_internal(a::ResElem, dict::IdDict) = parent(a)(deepcopy_internal(data(a), dict)) ``` `data(a)` is here...

Installer crash on `Result::unwrap()` at timeout

1

``` "name" = "Juliaup" "operating_system" = "Arch Linux Rolling Release [64-bit]" "crate_version" = "1.14.5" "explanation" = """ Panic occurred in file 'src/operations.rs' at line 1348 """ "cause" = "called `Result::unwrap()`...

x-ref https://github.com/oscar-system/Oscar.jl/pull/3700#discussion_r1596686047 cc @fingolfin A lot of code creating complexes/presentations/resolutions extracts the name of the base ring once and then uses it to set names of the parts using something...

Replace all methods of `promote_type` by `promote_rule`

3

Resolves https://github.com/JeffreySarnoff/ArbNumerics.jl/issues/67.

Docs out of date

1

The stable docs at https://fluxml.ai/MacroTools.jl/stable/ are for version v0.5.4, even though the most recent release is v0.5.13.

Random test failures in `NfOrd/PicardGroup.jl`

3

observed in the downstream tests in AA in https://github.com/Nemocas/AbstractAlgebra.jl/actions/runs/9224253991/job/25379194623?pr=1715#step:7:169 ```julia Error During Test at /home/runner/.julia/packages/Hecke/SZzwT/test/NfOrd/PicardGroup.jl:61 Got exception outside of a @test AssertionError: $(Expr(:escape, :(nbits(pp) < 10000))) Stacktrace: [1] macro expansion...