Lars Göttgens

Sort out deprecations and aliases

1

This needs https://github.com/Nemocas/Nemo.jl/pull/1704 to be available, and the Nemo compat to be adapted accordingly. This is an approach to sort deprecations and aliases as discussed with @fingolfin and already started...

```julia LocalFundamentalClass Serre: Test Failed at /home/runner/.julia/packages/Hecke/1fdag/test/LocalField/neq.jl:57 Expression: iszero(a) || valuation(a) > 20 Stacktrace: [1] macro expansion @ ~/.julia/packages/Hecke/1fdag/test/LocalField/neq.jl:57 [inlined] [2] macro expansion @ /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.6/Test/src/Test.jl:1[151](https://github.com/Nemocas/AbstractAlgebra.jl/actions/runs/8281920352/job/22661589864?pr=1636#step:7:152) [inlined] [3] top-level scope @...

Remove overloading `promote_type`

1

Resolves https://github.com/JuliaInterop/CxxWrap.jl/issues/425 in the way that is outlined in the docstrings ```julia help?> Base.promote_type promote_type(type1, type2, ...) Promotion refers to converting values of mixed types to a single common type....

After running `Pkg.test(Oscar)` locally, one gets two files `test/p.mrdi` and `test/q.mrdi` that are not ignored by git. I would expect them to be cleaned up by the test process afterwards...

Create misc files to accumulate pirated methods...

1

...to ease moving them downstream eventually. This approach was suggested in the last triage meeting by (I unfortunately cannot remember). I furthermore started moving some things that are very obviously...

Move banner hiding code to a separate package?

2

It seems to me that this is not particularly a feature that is tied to AA, but could be interesting for other packages as well that do not want the...

Add `Base.vec(M::MatElem)`

5

The code originates in https://github.com/oscar-system/Oscar.jl/blob/597398c594796cd2abbd8749977cb3f2a20eefb2/experimental/GModule/GModule.jl#L1451, but I want to use it in other parts of Oscar, that should not depend on experimental. So the cleanest solution is to add it...

Remove `rand` hacks and use `make` instead

8

All over AA, there are custom `rand` methods, that insert the RNG as a first argument, e.g. https://github.com/Nemocas/AbstractAlgebra.jl/blob/06b8630f73586b6dc425bcbe42e525e193e2c3be/docs/src/rand.md?plain=1#L117-L125 In particular, they change `rand(make(S, 1:3, -10:10))` to `rand(S, 1:3, -10:10)`. The...

It would be great to have a `evaluate` function for `FreeAssAlgElem`, similar to the one for polynomials.

Enabling the ambiguity report in test/Aqua.jl currently reports 622 ambiguities (with Julia 1.9). 587 of these are du to `rand` (see https://github.com/Nemocas/AbstractAlgebra.jl/issues/1388), which leaves 35. Most of these seem to...