one.com-ddns-python-script icon indicating copy to clipboard operation
one.com-ddns-python-script copied to clipboard

added docker capabilities

Open sim0nsen opened this issue 3 years ago • 1 comments

I'm not sure what the format of the script should be in order to support both docker and executing it directly from python. But this is an initial idea :)

sim0nsen avatar Apr 07 '22 07:04 sim0nsen

Sorry for the late response, I kind of forgot about this project.

Generally looks good so far but I dislike the Idea of reading the config from environment variables. It's great for docker but kind of terrible if you want to run it as a normal python script without the docker container. Maybe use command line parameters instead?

Also, feel free to add yourself to the list of contributors at the top of the script and bump the version, something like

    #################################
    ##                             ##
    ##     one.com DDNS Script     ##
    ##                             ##
    #################################
    | Version      | 2.4            |
    +--------------+----------------+
    | Last Updated | 2022-12-05     |
    +--------------+----------------+

    +----------------+-------------------------+
    | Initial Author | Lugico <[email protected]> |
    +----------------+-------------------------+
    | Contributors   | Vigge                   |
    |                | sim0nsen                |
    +----------------+-------------------------+

lgc-4 avatar Dec 05 '22 16:12 lgc-4