one.com-ddns-python-script icon indicating copy to clipboard operation
one.com-ddns-python-script copied to clipboard

docker support?

Open sim0nsen opened this issue 3 years ago • 4 comments

Hi, Really like your script, did some modifications to it, to support loading variables from environment settings. I have a version that is docker compatible. Would that be of interest as a feature?

sim0nsen avatar Apr 04 '22 20:04 sim0nsen

Hi, sorry I hadn't checked github in a while. I've never personally used docker but making the script docker compatible definitely sounds like a great idea. Mind creating a Pull Request so I can look into it?

lgc-4 avatar Apr 06 '22 15:04 lgc-4

Yeah no problem ;) Im new to GitHub so might need some guidance? I’ve cloned the repo, made my changes in a feature branch. So do I create a pr from my branch to master, directly from my git client? I tried pushing my branch, but that was not allowed ;)

sim0nsen avatar Apr 06 '22 15:04 sim0nsen

I think you have to create a Fork of my Repo on your GitHub, create a feature branch on there and then make the pr Maybe this helps

lgc-4 avatar Apr 06 '22 15:04 lgc-4

Thx, will look into it

sim0nsen avatar Apr 06 '22 16:04 sim0nsen