Special characters in the password results in no password being sent to SonarTfsAnnotate.exe

[artisan-jimmy]

I've noticed that having special characters causes the password to be sent as an empty string to SonarTfsAnnotate.exe. The password I've tested with contains the following special characters: #, ? and ( Not sure what character is the culprit, but I've verified this by modifying the SonarTfsAnnotate.exe by adding the following:

using (var sw = new StreamWriter("C:\\temp\\scm-tfvc.log", true))
{
    sw.WriteLine($"un: [{username}]");
    sw.WriteLine($"pw: [{password}]");
    sw.Flush();
}

[lg2de]

I've no idea why the mentioned characters may cause the described behavior. I myself do not recommend to use username and password. Please use PAT instead for security reasons. (The feature was implemented before I took ownership for this repo.)

So, if I invest time in this issue I would remove support for username/password. You are welcome to start more detailed analysis. A pull request is welcome.