rss-extender icon indicating copy to clipboard operation
rss-extender copied to clipboard

Mac&i feeds items with broken img tag

Open aschilling opened this issue 9 years ago • 3 comments
trafficstars

Hi,

first of all. Thank you for your great work, I rely on rss extender every day and it works great so far. Unfortunately, the img tags from heise posts (especiall from mac&i) are not closed anymore and thus dont work. Can you reproduce the issue?

Thanks in advance.

Andy

aschilling avatar Jul 29 '16 15:07 aschilling

The image tags do not need to be closed, don't they? Or what do you mean by closing?

I do not use this feed in my rss reader, so by looking only at the rss feed source code from rss-extender i cannot see an issue. Can you please pick a concrete example from a recent article?

Strubbl avatar Aug 01 '16 21:08 Strubbl

Hi,

I looked at the issue over the weekend and I think I found the problem. In particular, it is a problem for many feedreaders if an image path begins with "//". As soon as I replaced "//" with "https://". images were successfully displayed.

However, the issue does not only occur with images in the heise feed but also in other feeds. Thus, I think a global search and replace rule would be most appropriate.

What do you think?

Cheers

Andy

aschilling avatar Aug 08 '16 16:08 aschilling

Sounds reasonable to me. Can you please create a pull request with a proposal?

Strubbl avatar Aug 08 '16 20:08 Strubbl