theme_bandit

theme_bandit copied to clipboard

The way that css files are renamed, and the placement of css style load statements is changed when the frontpage is "cloned" leads to loss of preservation of css "load...

Tectract

Right now the file paths aren't very flexible (running individual tests causes fixture loading issues). They should all be migrated to use File.expand_path

dchuk

`` Pretty sure this is just Google literally preventing the downloading of their fonts. Should add some logic to detect fonts.googleapis.com domain and only preserve the `` rather than trying...

dchuk

#5 - Fixed link_tags method - added new test for CSSParser module

dchuk

Fixed some methods that were causing tests to not run

dchuk

trivial PR, just changing .gitignore since I'm using rubymine

dchuk

link_tags method failing on <link> tags with no rel .value()

1

`/theme_bandit-0.0.9/lib/theme_bandit/parser/css.rb:13:in`block in link_tags': undefined method `value' for nil:NilClass (NoMethodError)` Relevant method: https://github.com/lfender6445/theme_bandit/blob/master/lib/theme_bandit/parser/css.rb#L11 Example tag: `` I can probably patch this later today. EDIT: Updated with correct failing tag

dchuk