next-with-apollo icon indicating copy to clipboard operation
next-with-apollo copied to clipboard

Missing meta data when upgrading from 4.3.0 to 5.0.1

Open MM3y3r opened this issue 4 years ago • 2 comments

https://github.com/garmeeh/next-seo/issues/383 https://github.com/garmeeh/next-seo/issues/383#issuecomment-645457395

Just wanted to let you know, that we had a major outage in production yesterday due an upgrade from 4.3.0 to 5.0.1. All our meta data went missing and instead defaulted to the fallback meta data. That resulted in assets becoming un-sharable as no crawlers could see the meta data anymore. Also SEO was a mess. We are not sure what EXACTLY the root cause was, but it seems some functionality may not be backwards compatible.

Thank you for your work on this library. Using it has worked very well up until now. With the rollback it is also working fine again.

MM3y3r avatar Jun 18 '20 09:06 MM3y3r

Since 5.0.0 '@apollo/react-ssr' is not included. You need to import getDataFromTree and pass it. From the readme:

import { getDataFromTree } from '@apollo/react-ssr';

export default withApollo(Index, { getDataFromTree });

chemicalkosek avatar Jun 18 '20 09:06 chemicalkosek

We are currently testing your suggestion. Will let you know whether that fixed it soon.

MM3y3r avatar Jun 19 '20 09:06 MM3y3r