lingua-franca icon indicating copy to clipboard operation
lingua-franca copied to clipboard

Published 20 hours ago • verified publisher icon lf-lang

Reaction number in diagram doesn't match messages

Open edwardalee opened this issue 1 year ago • 2 comments

The reaction number in the diagrams starts with 1, but at least in the C target, it starts with 0. This means there is an off-by-one mismatch between error messages and the diagram. Can we change the diagram to start at 0? Do other targets also start at 0?

edwardalee avatar May 25 '23 13:05 edwardalee

I wasn't aware of this issue before. In C++ target, reaction names start at 1 (because they are displayed this way in the diagrams). I don't know about the other targets.

cmnrd avatar Aug 18 '23 09:08 cmnrd

How should we handle this? Should we change the diagrams and the numbering in targets that currently start counting at 1 (as proposed by @soerendomroes in #1950), or should we change the numbering in the C target?

cmnrd avatar Sep 08 '23 11:09 cmnrd