eve icon indicating copy to clipboard operation
eve copied to clipboard
verified publisher icon lf-edge

Bump golang

Open christoph-zededa opened this issue 6 months ago • 2 comments

Description

was https://github.com/lf-edge/eve/pull/5025 - but reopen is not allowed

this bumps some packages, including golang to 1.24.4
to prevent:
GO-2025-3563
GO-2025-3749
GO-2025-3750
GO-2025-3751

OSV checker is complaining, e.g.: https://github.com/lf-edge/eve/actions/runs/15906835554/job/44863871543?pr=4992

How to test and validate this PR

run OSV checker

and

strings /containers/services/pillar/rootfs/opt/zededa/bin/zedbox | grep "1.24.4"

Changelog notes

this bumps some packages, including golang to 1.24.4
to prevent:
GO-2025-3563
GO-2025-3749
GO-2025-3750
GO-2025-3751

PR Backports

No, because it seems the vulns are not severe.

Here is the list of current LTS branches (it should be always up to date):

  • 14.5-stable: No
  • 13.4-stable: No

Checklist

  • [x] I've provided a proper description
  • [x] I've added the proper documentation
  • [x] I've tested my PR on amd64 device
  • [ ] I've tested my PR on arm64 device
  • [x] I've written the test verification instructions
  • [x] I've set the proper labels to this PR

And the last but not least:

  • [x] I've checked the boxes above, or I've provided a good reason why I didn't check them.

Please, check the boxes above after submitting the PR in interactive mode.

christoph-zededa avatar Jun 27 '25 17:06 christoph-zededa 

2025-06-27T17:57:27.5226604Z #8 [build-base  9/18] ADD --chown=builder:abuild https://git.musl-libc.org/cgit/musl/snapshot/v1.2.3.tar.gz /var/cache/distfiles/musl-v1.2.3.tar.gz
2025-06-27T17:57:27.5229584Z #8 ERROR: invalid response status 502

oO

christoph-zededa avatar Jun 27 '25 18:06 christoph-zededa

/rerun red

christoph-zededa avatar Jun 28 '25 17:06 christoph-zededa

Is it you, @christoph-zededa, who is breaking grub? )

Error: error building "lfedge/eve-grub:4ef677a75fcd67bed78c9f84691ea78d11e1c69c": error building for arch riscv64: failed to solve: process "/bin/sh -c ./bootstrap --gnulib-srcdir=/gnulib || ./autogen.sh" did not complete successfully: exit code: 1
2025/06/28 17:11:52 error during command execution: error building "lfedge/eve-grub:4ef677a75fcd67bed78c9f84691ea78d11e1c69c": error building for arch riscv64: failed to solve: process "/bin/sh -c ./bootstrap --gnulib-srcdir=/gnulib || ./autogen.sh" did not complete successfully: exit code: 1
make: *** [Makefile:1087: eve-grub] Error 1

Or do we have a broken master again? )

OhmSpectator avatar Jun 29 '25 10:06 OhmSpectator

Is it you, @christoph-zededa, who is breaking grub? )

Error: error building "lfedge/eve-grub:4ef677a75fcd67bed78c9f84691ea78d11e1c69c": error building for arch riscv64: failed to solve: process "/bin/sh -c ./bootstrap --gnulib-srcdir=/gnulib || ./autogen.sh" did not complete successfully: exit code: 1
2025/06/28 17:11:52 error during command execution: error building "lfedge/eve-grub:4ef677a75fcd67bed78c9f84691ea78d11e1c69c": error building for arch riscv64: failed to solve: process "/bin/sh -c ./bootstrap --gnulib-srcdir=/gnulib || ./autogen.sh" did not complete successfully: exit code: 1
make: *** [Makefile:1087: eve-grub] Error 1

Or do we have a broken master again? )

it is broken only for riscv64? - I see packages (zededa-ubuntu-2204, amd64, generic) being successful...

I change gnulib to a different repository, but with the same revision: https://github.com/lf-edge/eve/pull/5027/commits/9563bdd91bd74b29cc8fe7efc844cd2d3dd46903

christoph-zededa avatar Jun 29 '25 14:06 christoph-zededa

let's try with parallel build ...

christoph-zededa avatar Jul 01 '25 09:07 christoph-zededa

So, let's try parallel build again.

christoph-zededa avatar Jul 02 '25 17:07 christoph-zededa

still same error:

make: *** [Makefile:1109: eve-pillar] Error 1
Error: error building "lfedge/eve-bsp-imx:150a728740d9b696bf656f4fd99df3d11b92e428": error building for arch amd64: failed to solve: lfedge/eve-alpine:523254c1b0728948a16a02115eb817f27c00977f: failed to resolve source metadata for docker.io/lfedge/eve-alpine:523254c1b0728948a16a02115eb817f27c00977f: docker.io/lfedge/eve-alpine:523254c1b0728948a16a02115eb817f27c00977f: not found
2025/07/02 17:51:14 error during command execution: error building "lfedge/eve-bsp-imx:150a728740d9b696bf656f4fd99df3d11b92e428": error building for arch amd64: failed to solve: lfedge/eve-alpine:523254c1b0728948a16a02115eb817f27c00977f: failed to resolve source metadata for docker.io/lfedge/eve-alpine:523254c1b0728948a16a02115eb817f27c00977f: docker.io/lfedge/eve-alpine:523254c1b0728948a16a02115eb817f27c00977f: not found
------
make: *** [Makefile:1109: eve-bsp-imx] Error 1
Error: error building "lfedge/eve-fscrypt:848281b21913622ea5bd03713b08fed1c2646cc9": error building for arch amd64: failed to solve: lfedge/eve-alpine:523254c1b0728948a16a02115eb817f27c00977f: failed to resolve source metadata for docker.io/lfedge/eve-alpine:523254c1b0728948a16a02115eb817f27c00977f: docker.io/lfedge/eve-alpine:523254c1b0728948a16a02115eb817f27c00977f: not found
2025/07/02 17:51:14 error during command execution: error building "lfedge/eve-fscrypt:848281b21913622ea5bd03713b08fed1c2646cc9": error building for arch amd64: failed to solve: lfedge/eve-alpine:523254c1b0728948a16a02115eb817f27c00977f: failed to resolve source metadata for docker.io/lfedge/eve-alpine:523254c1b0728948a16a02115eb817f27c00977f: docker.io/lfedge/eve-alpine:523254c1b0728948a16a02115eb817f27c00977f: not found
make: *** [Makefile:1109: eve-fscrypt] Error 1
Error: error building "lfedge/eve-debug:bbc3dd437f72e76be9d72b2ed7d268b2108fed16": error building for arch amd64: failed to solve: lfedge/eve-alpine:523254c1b0728948a16a02115eb817f27c00977f: failed to resolve source metadata for docker.io/lfedge/eve-alpine:523254c1b0728948a16a02115eb817f27c00977f: docker.io/lfedge/eve-alpine:523254c1b0728948a16a02115eb817f27c00977f: not found
2025/07/02 17:51:14 error during command execution: error building "lfedge/eve-debug:bbc3dd437f72e76be9d72b2ed7d268b2108fed16": error building for arch amd64: failed to solve: lfedge/eve-alpine:523254c1b0728948a16a02115eb817f27c00977f: failed to resolve source metadata for docker.io/lfedge/eve-alpine:523254c1b0728948a16a02115eb817f27c00977f: docker.io/lfedge/eve-alpine:523254c1b0728948a16a02115eb817f27c00977f: not found
make: *** [Makefile:1109: eve-debug] Error 1
Error: error building "lfedge/eve-acrn:f93be016c6f30a6ea4dd89584ae667147e4a4fe7": error building for arch amd64: failed to solve: lfedge/eve-alpine:523254c1b0728948a16a02115eb817f27c00977f: failed to resolve source metadata for docker.io/lfedge/eve-alpine:523254c1b0728948a16a02115eb817f27c00977f: docker.io/lfedge/eve-alpine:523254c1b0728948a16a02115eb817f27c00977f: not found
------
 > [internal] load metadata for docker.io/lfedge/eve-alpine:523254c1b0728948a16a02115eb817f27c00977f:
------
2025/07/02 17:51:14 error during command execution: error building "lfedge/eve-acrn:f93be016c6f30a6ea4dd89584ae667147e4a4fe7": error building for arch amd64: failed to solve: lfedge/eve-alpine:523254c1b0728948a16a02115eb817f27c00977f: failed to resolve source metadata for docker.io/lfedge/eve-alpine:523254c1b0728948a16a02115eb817f27c00977f: docker.io/lfedge/eve-alpine:523254c1b0728948a16a02115eb817f27c00977f: not found
make: *** [Makefile:1109: eve-acrn] Error 1
Error: error building "lfedge/eve-nvidia:e55559bfb67bf214011d7b6079992fa8ccb72f41-nvidia-jp5": error building for arch amd64: failed to solve: lfedge/eve-alpine:523254c1b0728948a16a02115eb817f27c00977f: failed to resolve source metadata for docker.io/lfedge/eve-alpine:523254c1b0728948a16a02115eb817f27c00977f: docker.io/lfedge/eve-alpine:523254c1b0728948a16a02115eb817f27c00977f: not found
2025/07/02 17:51:14 error during command execution: error building "lfedge/eve-nvidia:e55559bfb67bf214011d7b6079992fa8ccb72f41-nvidia-jp5": error building for arch amd64: failed to solve: lfedge/eve-alpine:523254c1b0728948a16a02115eb817f27c00977f: failed to resolve source metadata for docker.io/lfedge/eve-alpine:523254c1b0728948a16a02115eb817f27c00977f: docker.io/lfedge/eve-alpine:523254c1b0728948a16a02115eb817f27c00977f: not found
make: *** [Makefile:1109: eve-nvidia] Error 1
Error: error building "lfedge/eve-mkimage-raw-efi:f0436e3d57e2cb7b2328c4b2f1887e5c10989454": error building for arch amd64: failed to solve: lfedge/eve-alpine:523254c1b0728948a16a02115eb817f27c00977f: failed to resolve source metadata for docker.io/lfedge/eve-alpine:523254c1b0728948a16a02115eb817f27c00977f: docker.io/lfedge/eve-alpine:523254c1b0728948a16a02115eb817f27c00977f: not found
------
 > [internal] load metadata for docker.io/lfedge/eve-alpine:523254c1b0728948a16a02115eb817f27c00977f:
------
2025/07/02 17:51:14 error during command execution: error building "lfedge/eve-mkimage-raw-efi:f0436e3d57e2cb7b2328c4b2f1887e5c10989454": error building for arch amd64: failed to solve: lfedge/eve-alpine:523254c1b0728948a16a02115eb817f27c00977f: failed to resolve source metadata for docker.io/lfedge/eve-alpine:523254c1b0728948a16a02115eb817f27c00977f: docker.io/lfedge/eve-alpine:523254c1b0728948a16a02115eb817f27c00977f: not found
make: *** [Makefile:1109: eve-mkimage-raw-efi] Error 1
#7 extracting sha256:b6b3d4e25020aa20fc59e42e5e2bee154e89c2cb6a7badfa20e2db5185b0e702 4.0s done

https://github.com/lf-edge/eve/pull/5028#issuecomment-3022995047

christoph-zededa avatar Jul 02 '25 17:07 christoph-zededa

Didn't we already fix that gnulib grub build failure for riscv?

eriknordmark avatar Jul 07 '25 22:07 eriknordmark

Didn't we already fix that gnulib grub build failure for riscv?

Yesterday I tried to build it on my ARM Mac and I see the same issue there.

christoph-zededa avatar Jul 08 '25 10:07 christoph-zededa

Didn't we already fix that gnulib grub build failure for riscv?

My mistake, somehow the $ in ${GNULIB_REVISION} got lost.

christoph-zededa avatar Jul 09 '25 09:07 christoph-zededa

@christoph-zededa go tests is failing with: 2025-07-09T12:50:40.5169865Z === Failed 2025-07-09T12:50:40.5170214Z === FAIL: nireconciler TestStaticAndConnectedRoutes (0.69s)

Also there is a warning around a race condition for another test.

Details in the logs for the go tests.

eriknordmark avatar Jul 11 '25 18:07 eriknordmark

@christoph-zededa go tests is failing with: 2025-07-09T12:50:40.5169865Z === Failed 2025-07-09T12:50:40.5170214Z === FAIL: nireconciler TestStaticAndConnectedRoutes (0.69s)

Also there is a warning around a race condition for another test.

Details in the logs for the go tests.

I saw the same test failing here: https://github.com/lf-edge/eve/pull/4992#issuecomment-3044920340 according to @milan-zededa it still works as expected

What is the second one? I searched for DATA RACE but only got one match.

christoph-zededa avatar Jul 14 '25 09:07 christoph-zededa

/rerun red

christoph-zededa avatar Jul 29 '25 09:07 christoph-zededa

It looks to me like d8f88c1 doesn't change anything... How is the golang version updated?

see discussion here https://github.com/lf-edge/eve/pull/5027#discussion_r2212620224 ;-) short version: I just trigger apk to get the newest packages

christoph-zededa avatar Jul 30 '25 09:07 christoph-zededa

Failed to generate URL to download logs.

@OhmSpectator any idea how to see the "Go Tests" logs?

christoph-zededa avatar Aug 04 '25 11:08 christoph-zededa

@christoph-zededa regarding Go Tests:

System.IO.IOException: No space left on device : '/home/runner/actions-runner/cached/_diag/Worker_20250804-092626-utc.log'

I don't think this is going to work since it runs on GH runners....

rene avatar Aug 04 '25 11:08 rene

@christoph-zededa regarding Go Tests:

System.IO.IOException: No space left on device : '/home/runner/actions-runner/cached/_diag/Worker_20250804-092626-utc.log'

I don't think this is going to work since it runs on GH runners....

Maybe let's try to use a bigger GH runner for that? @dautovri what can we afford?

OhmSpectator avatar Aug 05 '25 10:08 OhmSpectator

/rerun red

christoph-zededa avatar Aug 06 '25 09:08 christoph-zededa

eve (arm64, kvm, nvidia-jp6):

0.972 ERROR: Failed to create usr/include/linux/ethtool_netlink.h: No space left on device

seems like the macbook runners don't have enough space ...

christoph-zededa avatar Aug 06 '25 16:08 christoph-zededa

eve (arm64, kvm, nvidia-jp6):

0.972 ERROR: Failed to create usr/include/linux/ethtool_netlink.h: No space left on device

seems like the macbook runners don't have enough space ...

yes, I've cleaned 3 of them...

rene avatar Aug 06 '25 16:08 rene

/rerun red

christoph-zededa avatar Aug 06 '25 16:08 christoph-zededa

/rerun red

christoph-zededa avatar Aug 07 '25 14:08 christoph-zededa

/rerun red

christoph-zededa avatar Aug 07 '25 15:08 christoph-zededa

In the end we got 1.24.6:

[pillar] root@linuxkit-525400123456:/$ strings /opt/zededa/bin/zedbox | grep go1
.24.6
go1.24.6
go1.24.6

christoph-zededa avatar Aug 11 '25 10:08 christoph-zededa

In the end we got 1.24.6:

[pillar] root@linuxkit-525400123456:/$ strings /opt/zededa/bin/zedbox | grep go1
.24.6
go1.24.6
go1.24.6

ok, that's the latest stable version. There was a new build for Alpine on Aug. 8th, but I think we can postpone another bump up for a bit...

https://pkgs.alpinelinux.org/packages?name=go&branch=edge&repo=community&arch=x86_64&origin=&flagged=&maintainer=

rene avatar Aug 11 '25 11:08 rene

but I think we can postpone another bump up for a bit...

this did not age well: https://github.com/lf-edge/eve/pull/5171#issuecomment-3188531064 ;-)

christoph-zededa avatar Aug 14 '25 14:08 christoph-zededa