eve icon indicating copy to clipboard operation
eve copied to clipboard

Check docker hashes parallel and safe roughly 1 second every time

Open christoph-zededa opened this issue 6 months ago • 1 comments

Description

Check linuxkit tags in parallel and save time.

PR dependencies

https://github.com/linuxkit/linuxkit/pull/4130

How to test and validate this PR

make any docker hash inconsistent and run

make check-docker-hashes-consistency

Changelog notes

""

PR Backports

Checklist

  • [x] I've provided a proper description
  • [x] I've added the proper documentation
  • [x] I've tested my PR on amd64 device
  • [ ] I've tested my PR on arm64 device
  • [x] I've written the test verification instructions
  • [ ] I've set the proper labels to this PR

And the last but not least:

  • [ ] I've checked the boxes above, or I've provided a good reason why I didn't check them.

Please, check the boxes above after submitting the PR in interactive mode.

christoph-zededa avatar Jun 25 '25 18:06 christoph-zededa

/rerun red

christoph-zededa avatar Jun 26 '25 11:06 christoph-zededa

Do we save one second for the whole build, or one second for each Docker file we check?

For the whole build ;-) - so closing without merging is fine, too.

I just wanted to try out the parallel linuxkit (and I found a bug: https://github.com/linuxkit/linuxkit/pull/4130 )

christoph-zededa avatar Jul 08 '25 08:07 christoph-zededa

@christoph-zededa can we easily fix the issue, reported by OSV?

OhmSpectator avatar Jul 30 '25 13:07 OhmSpectator

@christoph-zededa can we easily fix the issue, reported by OSV?

let's see, perhaps now ...

christoph-zededa avatar Jul 30 '25 14:07 christoph-zededa