Fix an issue of cluster mode transition not terminating k3s

[naiming-zededa]

Description

Fix an issue seen recently the K3S was not terminated during transition

How to test and validate this PR

• need to compile with 'kubevirt' tag, and bring up the device. then transition to cluuster mode. Make sure at least on the 'seed server', the transition to cluster mode is successful. Meaning the 'kubectl show node' will display the 'etcd' in the ROLES.
• although such an issue of not terminating the K3S process is a corner case, and it rarely happens to hit during the transition.

Test Done: I have tested this patch in my own kubevirt setup, does not normal cluster transition bring up. It works fine.

Changelog notes

Fix an issue of cluster mode transition not terminating k3s process

Checklist

• [x] I've provided a proper description
• [ ] I've added the proper documentation
• [x] I've tested my PR on amd64 device
• [ ] I've tested my PR on arm64 device
• [ ] I've written the test verification instructions
• [ ] I've set the proper labels to this PR

[naiming-zededa]

description updated.

[rene]

@naiming-zededa , as @OhmSpectator pointed out, it's really important to have the PR description filled according to the template, specially because it helps to run scripts to fetch information and help maintainers create the documentation for testing and validation. I still see some issues with this PR:

Major:

• Mixed text of the commits before the description
• No changelog information was provided (I think it's needed in this case since you are not fixing CI/CD stuff, build stuff, etc, that wouldn't require changelog notes)

Minor:

• Empty sections, you can remove them
• You don't need to put spaces in the items [x] so it gets correctly rendered by the GH page.

I just fixed everything, but you still need to provide the Changelog information, please.

[naiming-zededa]

I just fixed everything, but you still need to provide the Changelog information, please.

Got it, thanks @rene

[naiming-zededa]

update @rene, please review.

[eriknordmark]

@naiming-zededa try rebasing on master to see if that fixes the kubevirt build issue

[naiming-zededa]

@naiming-zededa try rebasing on master to see if that fixes the kubevirt build issue

rebased to see.

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 18.56%. Comparing base (ed461a3) to head (2189893). Report is 30 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #4984   +/-   ##
=======================================
  Coverage   18.56%   18.56%           
=======================================
  Files          18       18           
  Lines        2613     2613           
=======================================
  Hits          485      485           
  Misses       2046     2046           
  Partials       82       82           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:

• :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[rene]

@naiming-zededa , LGTM but you need to rebase...

[naiming-zededa]

@rene rebased. thanks.