eve icon indicating copy to clipboard operation
eve copied to clipboard

Add support for OnLogic FR201 device

Open dpoulios opened this issue 1 year ago • 3 comments

dpoulios avatar Oct 18 '24 14:10 dpoulios

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 20.93%. Comparing base (d1e13b8) to head (a1972fc). Report is 112 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4382      +/-   ##
==========================================
- Coverage   21.05%   20.93%   -0.13%     
==========================================
  Files          13       13              
  Lines        2878     2895      +17     
==========================================
  Hits          606      606              
- Misses       2146     2163      +17     
  Partials      126      126              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Oct 18 '24 15:10 codecov[bot]

@rene is part of this in #4395 ?

eriknordmark avatar Oct 23 '24 12:10 eriknordmark

@rene is part of this in #4395 ?

Only the kernel update commit @eriknordmark , so @dpoulios doesn't need to include the kernel hash update here...

rene avatar Oct 24 '24 09:10 rene

The riscv build failed in https://github.com/lf-edge/eve/actions/runs/11522045471?pr=4382

eriknordmark avatar Oct 26 '24 21:10 eriknordmark

The riscv build failed in https://github.com/lf-edge/eve/actions/runs/11522045471?pr=4382

The riscv64 build fails because the package gnutls-dev (needed to build the updated u-boot) is not available in alpine 3.16 for risc. It becomes available in 3.20. Should we update alpine?

dpoulios avatar Nov 01 '24 08:11 dpoulios

It becomes available in 3.20. Should we update alpine?

Can't we work around it for now? We can update Alpine to 3.20, but it can bring some other issues in other packages; that would be nice to resolve in a dedicated PR, I would say.

So, we

* either postpone this PR merge until we do the Alpine upgrade to 3.20 in a dedicated PR

* or introduce a workaround here for 3.16 and do the upgrade later

Our option depends on how urgent we expect the OnLogic device support.

Ok, I was able to build it without the gnutls_dev package. This is needed just to build the mkeficapsule tool of u-boot. So, we can safely disable it.

I will upload a patch shortly.

dpoulios avatar Nov 04 '24 14:11 dpoulios

It becomes available in 3.20. Should we update alpine?

Can't we work around it for now? We can update Alpine to 3.20, but it can bring some other issues in other packages; that would be nice to resolve in a dedicated PR, I would say. So, we

* either postpone this PR merge until we do the Alpine upgrade to 3.20 in a dedicated PR

* or introduce a workaround here for 3.16 and do the upgrade later

Our option depends on how urgent we expect the OnLogic device support.

Ok, I was able to build it without the gnutls_dev package. This is needed just to build the mkeficapsule tool of u-boot. So, we can safely disable it.

I will upload a patch shortly.

Thank you @dpoulios , that's perfect...

rene avatar Nov 04 '24 14:11 rene