lf-edge
Add volumeattach/volumedetach API
Longhorn volumes are attached to a node where the app is running. Since the volumes we create in eve are RWO, ie only one node can attach at a time, during failover we need to make sure the node that failed is detached from the volume.
The node that is taking over will automatically attach to the volume if no other node is attached. Also, generally its very safe to detach and then attach to avoid any potential corruption.
I assume there will be a follow-up PR to call this APIs. Is that correct?
@andrewd-zededa can you review?
I assume there will be a follow-up PR to call this APIs. Is that correct?
@andrewd-zededa can you review?
That's correct. We are trying to split PRs so that they are independent and can compile, easy to review too.
LGTM mostly, I think we need a some comments around the volumeattachment logging to ensure they are not downgraded to Function/Trace in the future.
@andrewd-zededa, @zedi-pramodh was this comment addressed?
LGTM mostly, I think we need a some comments around the volumeattachment logging to ensure they are not downgraded to Function/Trace in the future.
@andrewd-zededa, @zedi-pramodh was this comment addressed?
I don't understand what Andrew meant actually :)
This needs to be rebased on master - the SPDX check workflow has issues with misdetecting issues.
This needs to be rebased on master - the SPDX check workflow has issues with misdetecting issues.
Rebased to master and amended the commit
The same Eden issue =((((
Those should be completely unrelated. This code path is not even executed yet.