eve icon indicating copy to clipboard operation
eve copied to clipboard

[WIP] Add recover-tpm tool to debug container

Open shjala opened this issue 1 year ago • 5 comments

shjala avatar Feb 12 '24 13:02 shjala

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 19.70%. Comparing base (d864826) to head (9d71458). Report is 33 commits behind head on master.

:exclamation: Current head 9d71458 differs from pull request most recent head faf64d7. Consider uploading reports for the commit faf64d7 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3756      +/-   ##
==========================================
+ Coverage   17.51%   19.70%   +2.18%     
==========================================
  Files           3      235     +232     
  Lines         805    51708   +50903     
==========================================
+ Hits          141    10187   +10046     
- Misses        629    40780   +40151     
- Partials       35      741     +706     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 12 '24 14:02 codecov[bot]

My only advice is: could you please add a few words about the tool in higher level docs, like docs/DEBUG.md or docs/SECURITY.md, because to reach the pkg/debug/docs can be difficult, but having a few words in docs/ can have more chances to be read.

rouming avatar Feb 12 '24 15:02 rouming

I see some yetus issues in https://github.com/lf-edge/eve/actions/runs/7874772444?pr=3756

eriknordmark avatar Feb 13 '24 20:02 eriknordmark

@eriknordmark fixed. @rouming added.

Currently it builds the tool in debug container but not copied to the container itself. Once I figured out how to make it part of release I'll commit the recover-tpm.sh.

shjala avatar Feb 14 '24 12:02 shjala

I'm going to rework this, major changes to come.

shjala avatar Mar 07 '24 12:03 shjala

see https://github.com/lf-edge/eve/pull/3867

shjala avatar Apr 18 '24 09:04 shjala