eve icon indicating copy to clipboard operation
eve copied to clipboard

Fix DeviceInfo output

Open giggsoff opened this issue 3 years ago • 1 comments

Inside device info message I can see unexpected termination symbols x86_64\x00\x00\x00.... Let's use unix.ByteSliceToString function to remove them.

Signed-off-by: Petr Fedchenkov [email protected]

giggsoff avatar Oct 13 '22 13:10 giggsoff

LGTM

vk-en avatar Oct 13 '22 17:10 vk-en

LGTM, but I don't undestand the original code using the machine arch for all three fields. But that's a separate bug.

Seems all commands we had previously in that place returns the same results. But yes, it is nice to understand our expectations here and modify separately if necessary.

I wonder if there are other places we get nul characters, such as the information we receive from dmidecode. @giggsoff do you have a way to check for them in the deviceinfo?

I can see the problem only here in my experiments.

giggsoff avatar Oct 17 '22 15:10 giggsoff