Refactoring arguments parsing

Open giggsoff opened this issue 3 years ago • 2 comments

We should avoid modifications of os.Args in zedbox to be able to start services in parallel. So we should refactor Run functions to pass arguments into explicitly. The current way of parsing arguments in every Run function may be refactored to use common functions we have in agentbase. This PR modifies the way of parsing arguments.

Oct 11 '22 12:10 giggsoff

Note that the golangcilint complaints for the Run functions can be turned off by adding //nolint:gocyclo

Oct 14 '22 23:10 eriknordmark

Note that the golangcilint complaints for the Run functions can be turned off by adding //nolint:gocyclo

I am not sure, I can see that annotation here (probably the link is not stable, let me paste the link to the code: https://github.com/lf-edge/eve/blob/598bb9d18706859daaf09a1ab87cde2e419a669e/pkg/pillar/cmd/tpmmgr/tpmmgr.go#L1373). But golangcilint still complain.

Oct 15 '22 10:10 giggsoff