Make function doActivate, hande{Modify,Create} less overloaded

Open zededa-yuri opened this issue 3 years ago • 1 comments

This PR is pure function renaming (and changing log messages to reflect that rename)

These was confusing me for a long time. These are not parts of any interfaces, nor any overloading in OOP sense. They do not have any good reason to not to have a bit more unique names.

Aug 08 '22 16:08 zededa-yuri

[the hostess took up a broom] @zededa-yuri do you plan to address comments from Milan and Erik and eventually finish this? or we can close it?

Oct 12 '22 13:10 rouming

We should consider structuring this differently, for instance by having FooConfig and FooStatus be interfaces or include an interface with a set of functions for HandleCreate,Modify,Delete plus Activate/Inactivate etc for the types which has a notion of active/inactive.

But as I've discussed with @zededa-yuri the approach in this PR to rename some functions doesn't bring any better structure hence it makes sense to close it.

Oct 20 '22 05:10 eriknordmark