eve icon indicating copy to clipboard operation
eve copied to clipboard

Do not run assets on release branch push and fix version of EVE-OS in EdenGCP

Open giggsoff opened this issue 3 years ago • 3 comments
trafficstars

We prepare assets only for default branch (snapshot) and for tagged version. So we should ignore release branches itself, only tags on them. Now we can see errors in assets workflow (Error response from daemon: manifest for lfedge/eve:8.5-kvm-amd64 not found: manifest unknown: manifest unknown). Let's remove that trigger and wait for the new tag on patch branch before publishing.

EdenGCP workflow uses workflow_run trigger. In that caseactions/checkout will pull default branch which is not expected. Let's get version of EVE-OS from the source tree.

giggsoff avatar Aug 02 '22 10:08 giggsoff

Looks like you removed all pushing for release branches. Is that the case? Or does the release branch push happen somewhere else?

eriknordmark avatar Aug 02 '22 15:08 eriknordmark

Looks like you removed all pushing for release branches. Is that the case? Or does the release branch push happen somewhere else?

We will not push non-tagged versions from release (patch) branches. I put comment about that: Publishing of patch branch updates ends with odd tags on dockerhub (for example lfedge/eve:8.5.1-1-g344965dda) and lead to error in assets workflow (Error response from daemon: manifest for lfedge/eve:8.5-kvm-amd64 not found: manifest unknown: manifest unknown).. If such docker tags expected, we should adjust Assets workflow.

giggsoff avatar Aug 02 '22 15:08 giggsoff

I reworked the PR to not prepare assets on release branch update. We still will make them on tag push event on release branch, it is separate trigger.

giggsoff avatar Aug 04 '22 09:08 giggsoff