eden icon indicating copy to clipboard operation
eden copied to clipboard

Workflows: Improve tpm part of test.yml name

Open uncleDecart opened this issue 1 year ago • 5 comments

What

Currently, jobs in test.yml are running following matrix:

  smoke:
    continue-on-error: true
    strategy:
      matrix:
        file_system: ['ext4', 'zfs']
        tpm: [true, false]

Which generates following name: Smoke tests (ext4, false) We want it to be something more meaningful like : Smoke tests (ext4, no-tpm)

How can we do that?

We can change tpm from boolean parameter to string and compare it to string throughout the test.yml.

Alternatively, if there's a way to change job names to

  smoke:
    continue-on-error: true
    strategy:
      matrix:
        file_system: ['ext4', 'zfs']
        tpm: [true, false]
    name: "Smoke tests ${{ matrix.file_system }} tpm-enabled : ${{ matrix.tpm }}

I prefer the latter, because it's less work and boolean comparison remains

uncleDecart avatar Nov 29 '23 08:11 uncleDecart

@milan-zededa what are your thoughts on this?

uncleDecart avatar Nov 29 '23 08:11 uncleDecart

What would the artifact name be like in the second case?

milan-zededa avatar Nov 29 '23 09:11 milan-zededa

What would the artifact name be like in the second case?

@milan-zededa "Smoke tests ext4 tpm-enabled : true"

uncleDecart avatar Nov 29 '23 14:11 uncleDecart

I would prefer the first option for the sake of better readability.

milan-zededa avatar Nov 29 '23 14:11 milan-zededa

Well, at least I tried :smiling_face_with_tear:

uncleDecart avatar Nov 29 '23 14:11 uncleDecart