eden icon indicating copy to clipboard operation
eden copied to clipboard

Remove viper config serialization

Open uncleDecart opened this issue 2 years ago • 7 comments
trafficstars

This continues work on removing viper from openevec package so that we can create default configuration structure and use it to call openevec functions in golang.

In this PR use EdenSetupArgs default generated config in config add function. That means that we remove configuration generated from templates (so there are no comments or spacing in file, just pure yml, we can, of course add template comments to struct fields in go file) Also we force cloudPrepare() function to use EdenSetupArgs, because before it fetched variables from viper, which creates unnecessary coupling and forces us to create file and use viper in openevec.

So far I played with default parameters, will try to change configurations.

uncleDecart avatar Nov 17 '23 10:11 uncleDecart

It looks like something broken: https://github.com/lf-edge/eden/actions/runs/6902762877/job/18780102814#step:11:21. As I can see there is double dist in path there.

giggsoff avatar Nov 21 '23 08:11 giggsoff

Let's try this one :)

uncleDecart avatar Nov 21 '23 09:11 uncleDecart

There are some more changes needed in test cmd

uncleDecart avatar Nov 21 '23 10:11 uncleDecart

Okaay, test cmd fixed, let's see how it runs :crossed_fingers:

uncleDecart avatar Nov 22 '23 12:11 uncleDecart

That's weird, locally smoke tests are running, in CI/CD tests are green, but I think they didn't run (10 mins is way to less for tests to finish)

uncleDecart avatar Nov 22 '23 12:11 uncleDecart

log_tests is failing, something is wrong with certificate path, looking into it...

uncleDecart avatar Nov 22 '23 12:11 uncleDecart

tests are passing, but we are failing on getting logs, checking what's up

uncleDecart avatar Nov 27 '23 13:11 uncleDecart