jade

docs: add a bunch of docs to dynamic outputs

1

There's a bunch of boilerplate due to https://github.com/facebook/buck2/issues/1046. Fixes: https://github.com/facebook/buck2/issues/1038

`//A/B/C` is a valid name for `//A/B/C:C`

8

> Prefer using the short name when referring to an eponymous target (`//x` instead of `//x:x`). If > you are in the same package, prefer the local reference (`:x` instead...

prelude/go: fix asan constraint to actually work

1

This looks like a copy paste error. Now, I don't know if it does anything even now, but it was definitely wrong before, right?

DefaultInfo docs: `attrs.output()` does not exist

1

https://buck2.build/docs/api/build/DefaultInfo/ gives the following in an example: ``` foo_binary = rule( impl=impl, attrs={ "srcs": attrs.list(attrs.source()), "out": attrs.output(), "stripped": attrs.output(), "debug_info": attrs.output(), "_cc": attrs.dep(default="//tools:cc", providers=[RunInfo]), "_strip_script": attrs.dep(default="//tools:strip", providers=[RunInfo]) ) ``` Besides...

buck starlark lint: show the warning name or suppression instructions

1

Currently the warning names and suppression comment are undocumented. The output should mention how to suppress a warning as well as what the actual warning code is, IMO, which it...

Synopsis: There are many different types of `str` that can be used in rules that have significant semantic meaning: sources, target selectors, and more. However, they're squashed into `str` at...

FYI this comment suggests that the behaviour believed in in #246 *is* the case. https://github.com/facebook/buck2/blob/b41f89757bdbef3b3993f9b0af5074b9d39a3421/app/buck2_server/src/daemon/state.rs#L151-L159 It sounds from #246 that this comment is straight up not the intended use case,...

LSP: diagnose missing identifiers in scope

1

It would be really helpful if the LSP could diagnose undefined identifiers in global scope that might need to be imported and produce LSP level diagnostics. I don't know how...

```rust #[starlark_value(type = "DynamicAction")] impl for StarlarkDynamicActions { static RES: MethodsStatic = MethodsStatic::new(); RES.methods(dynamic_actions_methods) } } impl for StarlarkDynamicActions Value

docs: Document what to do with a DynamicValue

2

Currently the DynamicValue docs page is totally empty: https://buck2.build/docs/api/build/DynamicValue/ It should link to the place from which they are obtained: https://buck2.build/docs/api/build/AnalysisActions/#analysisactionsdynamic_output_new As well as the https://buck2.build/docs/rule_authors/dynamic_dependencies/ page And it should...