geotorch icon indicating copy to clipboard operation
geotorch copied to clipboard

Complex numbers: hermitian and unitary

Open jpcorb20 opened this issue 2 years ago • 1 comments

Hello,

Thanks for the great library!

Do you plan to support cases on complex numbers like hermitian, skew-hermitian and unitary?

Thank you

jpcorb20 avatar Apr 13 '22 02:04 jpcorb20

There is no plan to support those yet, but I'd happily take a PR adding them.

Here you have an example of a PR that adds a new manifold to the library: https://github.com/Lezcano/geotorch/pull/31

It's worth noting the limited support of PyTorch when it comes to complex numbers and optimisers though: https://github.com/pytorch/pytorch/issues/59998 https://github.com/pytorch/pytorch/issues/65711

lezcano avatar Apr 13 '22 14:04 lezcano