lexxmark
Warning GCC and Clang : Empty lines : %option '-L'
Files generated by latest flex have some problems:
- build with GCC(v. 6+) Clang(v. 10+, apple Xcode) : [-Wmisleading-indentation] warnings fixed : flex/src/skel.l
- generate with '-L' options and use a %top directive leads to a lot of empty line ( sequence of '\n' ) and
a directive '#line' always generated for %top
fixed :
- flex/src/buf.c : fix incorrect comparison (!)
- flex/src/scan.c add a check for '-L'
Hello @dpasukhi,
Have you tried to pull request this change to the upstream Gnu flex project? I try to have minimal changes from original project to easily adopt new versions.
Regards, Alex
Dear @lexxmark , I researched a gnu flex project.
The fix with flex/src/scan.c is not correct ( need to fix scan,l ), but this fix not respons for empty line. The correction of this file is not needed in this patch ( I'll clean up this, if you interested in the integration of this bug ) Fix of gcc/clang warnings has been integrated in the last year within https://github.com/westes/flex/commit/a631f5da8d4fd60fbde7b06bcf43bc9a155c27d5 The fix resolved problems with '-L' options was been request in the last September in the https://github.com/westes/flex/pull/468
Best regards, Dmitry.
I'll clean up this, if you interested in the integration of this bug
Since flex releases happening very rarely let's cleanup this pull request and I will merge it.
Flex sources changed a lot since this PR and the possibly very soon next Flex release seems to have those issues fixed. If the next release here will be likely based on the updated flex version then the change now is possibly not the right thing.
No, only guesswork based on https://github.com/westes/flex/pull/480 and the referenced issue. "Looks like we are near". If any change is incorporated now it should be the bunch of changes from flex upstream, not this one which will lead to more conflicts for the later merge.