sharpsnmplib icon indicating copy to clipboard operation
sharpsnmplib copied to clipboard

Published 20 hours ago • verified publisher icon lextudio

ContextEngineID and contextName in v3 traps

Open mrinaldas opened this issue 4 years ago • 1 comments

Added a constructor to add EngineId(ContextEngineId) and ContextName in v3 trap message.

Same changes in pull request created by KristianVirkus:configurable-engine. The pull request was created on older version of the code, the library code have moved on quite a lot since then and the engine/pipeline code have even been split which make the PR merge cumbersome. Therefore created a PR with same changes plus resolving unit tests based on latest master branch.

Separate PR with relevant changes have been created for samples project as well.

mrinaldas avatar Apr 27 '20 20:04 mrinaldas

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Apr 27 '20 20:04 CLAassistant

Hi @lextm, Can this pull request be merged please? Thanks.

mrinaldas avatar Jan 30 '24 12:01 mrinaldas

Found a few more issues with this pull request. Will investigate further and decide what else is needed.

lextm avatar Feb 05 '24 08:02 lextm

Thank you.

mrinaldas avatar Feb 05 '24 10:02 mrinaldas

I cherry picked your commit that added the new constructor and also made some further changes in da4a39f430715af862435889dbee227ace4bef17. In that way there is no need to change the test cases and also match what snmptrap requires (both engine ID and context engine ID are now configurable).

Therefore, this pull request is no longer needed.

Thanks for your contribution.

lextm avatar Feb 06 '24 07:02 lextm

That's brilliant. Thank you so much. Appreciate your time and for accepting the changes. I shall keep an eye on the 12.5.3 release. Appreciate your brilliant work with the snmp library. Cheers.

mrinaldas avatar Feb 06 '24 08:02 mrinaldas