LexikJWTAuthenticationBundle icon indicating copy to clipboard operation
LexikJWTAuthenticationBundle copied to clipboard

Extending the Key Loader

Open MisterGlass opened this issue 7 years ago • 2 comments

I have an ops requirement to load my key from an envar. This looks easy to do, I just need to implement the KeyLoaderInterface and have my class injection into the JWSProvider

I could make the change to my keyloader in a compiler pass, but it would be nicer (in my eyes) to set it in the config (like the encoder service). Should I make the config change and submit a PR? Or is there not enough interest to warrant this as a feature?

MisterGlass avatar Apr 13 '17 20:04 MisterGlass

Hey @MisterGlass,

I plan to review a bit the "encoding" part of this bundle for a v3, things are going too far, we've somehow rewritten the JOSE library this bundle depends on to correct some bad/missing behaviours, we should have changed the default JOSE library instead, which is what will happen in 3.0.

So I propose to keep this open and keep using a compiler pass for solving this need until I start to rework this part of the bundle so that we have more visibility on what should be done (should happen very soon, keep you informed here).

Thanks

chalasr avatar Apr 27 '17 12:04 chalasr

Thanks. I actually ended up using a server level workaround for my problem, but this seems like a worthwhile feature.

MisterGlass avatar Apr 27 '17 12:04 MisterGlass