LexikJWTAuthenticationBundle icon indicating copy to clipboard operation
LexikJWTAuthenticationBundle copied to clipboard

JSONWebToken Token naming

Open Ahummeling opened this issue 2 years ago • 2 comments

First of all, thank you very much for this awesome bundle!

I came across a very straight forward exception message, and got a little annoyed with the wording:

{
  "code": 401,
  "message": "JWT Token not found"
}

The T in JWT stands for Token, so this reads out to "JSON Web Token Token not found". In my native language, this is considered a grammatical error, I am not sure if this is the case in english. More importantly, I am even less sure about whether this naming might've been intentional.

I wanted to submit a PR that "fixes" the occurrences of JWT Token by renaming them to JWT where it makes sense to do so. But I wanted to check first that such a PR would be appreciated in the first place.

Again thanks for the awesome bundle, I'm hoping to make it ever so slightly better.

Ahummeling avatar Feb 22 '23 20:02 Ahummeling

In my view, the acronym 'JWT' works well – a quick way to convey or refer to what you're talking about. In France, everyone says 'JWT token' in French conversations.

If you wish to make improvements, kindly provide a configuration option for the default error message. That way, everyone will be satisfied :)

Bryce-Colton avatar Nov 25 '23 08:11 Bryce-Colton

Same open issue here : https://github.com/lexik/LexikJWTAuthenticationBundle/issues/983#issue-1119596113

Bryce-Colton avatar Nov 25 '23 08:11 Bryce-Colton