LexikJWTAuthenticationBundle icon indicating copy to clipboard operation
LexikJWTAuthenticationBundle copied to clipboard

Drop PHP <7.1 and Symfony <5.3 support

Open herman-aka-wouter opened this issue 3 years ago • 4 comments

Fix for https://github.com/lexik/LexikJWTAuthenticationBundle/issues/996

For tag 3.x

herman-aka-wouter avatar Aug 10 '22 13:08 herman-aka-wouter

Awesome! Thanks for working on this @wouter-toppy.

chalasr avatar Aug 10 '22 14:08 chalasr

@chalasr still trying to test and fix the ci

herman-aka-wouter avatar Aug 10 '22 14:08 herman-aka-wouter

Looks good to me. I'll merge this very soon and send a follow-up PR to remove the whole security-guard integration.

chalasr avatar Aug 10 '22 14:08 chalasr

@chalasr tests completed. and on my part the issue is resolved

herman-aka-wouter avatar Aug 10 '22 15:08 herman-aka-wouter

@chalasr any idea when i can expect this to be merged (and tagged in 3.x) Dont know if you still have other pulls/issues you want to merge into the 3.x branch

the JWTRefreshTokenBundle Pull is merged already, and hopefully gets a tag soon.

after that this is the only thing that blocks our WMS upgrade to Symfony 6.1 and PHP 8.1. because we can't enable preloading because of the original issue of this pull

herman-aka-wouter avatar Aug 12 '22 13:08 herman-aka-wouter

Thank you @wouter-toppy.

chalasr avatar Aug 18 '22 15:08 chalasr

Note that I'm not going to tag 3.0 now, there is quite a lot of cleanup and work ongoing on 2.x before I can (should happen at some point by the end of the year). Of course meanwhile you can require the 3.x-dev version or some commit hash.

chalasr avatar Aug 18 '22 15:08 chalasr